Eliminate discard flicker by deriving play state directly from fetcher data#158
Merged
Eliminate discard flicker by deriving play state directly from fetcher data#158
Conversation
Agent-Logs-Url: https://github.com/ut-code/hitori-mahjong/sessions/9990eeb1-f0b8-4c16-a28d-cc04800d6349 Co-authored-by: tknkaa <145080781+tknkaa@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ut-code/hitori-mahjong/sessions/9990eeb1-f0b8-4c16-a28d-cc04800d6349 Co-authored-by: tknkaa <145080781+tknkaa@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ut-code/hitori-mahjong/sessions/9990eeb1-f0b8-4c16-a28d-cc04800d6349 Co-authored-by: tknkaa <145080781+tknkaa@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
tknkaa
April 24, 2026 05:47
View session
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
hitori-mahjong | 971ed61 | Apr 24 2026, 05:51 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a discard, optimistic UI disappeared when
discardFetcher.statereturned toidle, but theuseEffectsync into localgameStatehad not yet committed, causing a brief render of stale state. This change removes that async gap by making render state synchronous and derived.State source of truth
gameState(useState) and both sync effects (useEffect) fromapp/routes/play.tsx.Reference migration
gameStatetocurrentGameStatewhere base state is read.