Two bugfixes to parsing of GAMESS COSMO files.#34
Open
thomvet wants to merge 1 commit intousnistgov:masterfrom
Open
Two bugfixes to parsing of GAMESS COSMO files.#34thomvet wants to merge 1 commit intousnistgov:masterfrom
thomvet wants to merge 1 commit intousnistgov:masterfrom
Conversation
Collaborator
|
Can you provide a test file ? It would be nice to have tests run on every commit (more a comment for me than anything) |
Author
|
Yes, I will try to make one that has both features (Cl atom and only positive XYZ coordinates). Do you want to have it in https://github.com/usnistgov/COSMOSAC/tree/master/profiles/GAMESS_TEST ? Edit: will also include expected output file. |
Collaborator
|
Yes, that seems like a good location for the files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces two bugfixes for the parsing of GAMESS output files:
Previous regular expression only matched segments and atoms after the first minus sign appeared in the coordinate list. This is the case in the example file the script was tested against, but of course is not a general occurrence... (the molecule may be anywhere in the XYZ coordinates...).
GAMESS puts two letter atoms in all caps in the output file ("CL" for chlorine; chlorobenzene example below) which did not match with the covalent_radius dictionary. This is at least the case in the July 2024 release (most current).