Conversation
DisterDE
suggested changes
Oct 16, 2021
| } | ||
| vehicles.checkEngine(); | ||
| vehicles.checkTrailer();} | ||
|
|
|
|
||
| public class Car extends Vehicles{ | ||
|
|
||
| protected Car(String modelName, int wheelsCount) { |
| } | ||
|
|
||
| @Override | ||
| protected void check(Vehicles vehicles) { |
| public class Main { | ||
| public static void main(String[] args) { | ||
|
|
||
| Vehicles[] vehicles = new Vehicles[] { |
There was a problem hiding this comment.
Тип должен иметь единственное число, т.е. Vehicle
Comment on lines
+16
to
+18
| for (int i = 0; i < vehicles.length; i++) { | ||
| vehicles[i].check(vehicles[i]); | ||
| } |
There was a problem hiding this comment.
Следует заменить на foreach.
А где сама сервисная станция?
Почему мы вызываем у объекта Vehicle метод, который требует подачи себя же в качестве параметра?
Comment on lines
+10
to
+16
| public void check(Vehicles vehicles){System.out.println("Обслуживаем2 " + vehicles.getModelName()); | ||
| for (int i = 0; i < vehicles.getWheelsCount(); i++) { | ||
| vehicles.updateTyre(); | ||
| } | ||
| vehicles.checkEngine(); | ||
| vehicles.checkTrailer();} | ||
| } |
There was a problem hiding this comment.
Этот код общий с машиной, следовательно нужно как-то это решить.
Comment on lines
+35
to
+41
| public void checkEngine() { | ||
| System.out.println("Проверяем двигатель"); | ||
| } | ||
|
|
||
| public void checkTrailer() { | ||
| System.out.println("Проверяем прицеп"); | ||
| } |
There was a problem hiding this comment.
У велосипеда нет этих двух методов, а у машины нет трейлера.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.