feat rabbitmq: heartbeat and message headers support by sav-da · Pull Request #1129 · userver-framework/userver

sav-da · 2026-02-26T09:50:20Z

Add support for custom message headers
Enable configurable heartbeat interval for connection health checks

Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.

rabbitmq/src/urabbitmq/consumer_base_impl.cpp

rabbitmq/src/urabbitmq/impl/amqp_connection_handler.cpp

rabbitmq/src/urabbitmq/component.yaml

rabbitmq/include/userver/urabbitmq/typedefs.hpp

rabbitmq/src/urabbitmq/impl/amqp_connection_handler.cpp

rabbitmq/src/urabbitmq/consumer_base_impl.cpp

rabbitmq/src/urabbitmq/impl/amqp_connection_handler.cpp

rabbitmq/src/urabbitmq/impl/amqp_connection_handler.hpp

rabbitmq/src/urabbitmq/impl/amqp_connection_handler.cpp

rabbitmq/src/urabbitmq/component.yaml

rabbitmq/src/urabbitmq/impl/amqp_connection_handler.cpp

rabbitmq/src/tests/publish_consume_rmqtest.cpp

rabbitmq/src/urabbitmq/impl/amqp_connection_handler.cpp

rabbitmq/src/urabbitmq/impl/amqp_connection_handler.hpp

rabbitmq/src/urabbitmq/client_settings.cpp

rabbitmq/include/userver/urabbitmq/client_settings.hpp

sav-da · 2026-03-04T10:12:45Z

Обнаружил баг, занимаюсь доработками

sav-da · 2026-03-04T11:57:21Z

изначальный метод конвертации работал некорректно для любых типов кроме строк
переделал реализацию, вынес в отдельный файл и отдельный тест

rabbitmq/src/urabbitmq/impl/field_to_string.cpp

rabbitmq/include/userver/urabbitmq/typedefs.hpp

sav-da · 2026-03-06T14:29:53Z

@Malevrovich я в течении следующей недели подготовлю полноценную реализацию
на текущий момент опирался в основном на то что нужно для нашего проекта, но это не совсем верно с точки зрения userver.

приведу к полноценной реализации.

P.S. приношу извенения за прошедшее потраченное время. впредь постараюсь делать более качественные изменения

Malevrovich · 2026-03-06T14:54:32Z

@Malevrovich я в течении следующей недели подготовлю полноценную реализацию на текущий момент опирался в основном на то что нужно для нашего проекта, но это не совсем верно с точки зрения userver.

приведу к полноценной реализации.

P.S. приношу извенения за прошедшее потраченное время. впредь постараюсь делать более качественные изменения

Всё нормально, главное, что результат вырисовывается. Будем рады принять доработки

Malevrovich

Еще давайте добавим в функциональные тесты
userver/rabbitmq/function_tests
Проверку работы хедеров и проверку работы хартбита

rabbitmq/src/urabbitmq/impl/header_value.cpp

rabbitmq/include/userver/urabbitmq/typedefs.hpp

rabbitmq/src/urabbitmq/impl/amqp_connection_handler.cpp

rabbitmq/src/urabbitmq/impl/header_value.cpp

Malevrovich

Осталось немного мелочей. Включу прогон тестов, если падения будут относиться к изменениям, то их надо будет исправить

rabbitmq/functional_tests/basic_chaos/tests/test_rabbitmq.py

rabbitmq/src/urabbitmq/impl/amqp_connection_handler.cpp

Malevrovich

Выглядит хорошо. Нужен ребейз на master, мы там C++20 включили, запускаем CI и можно мержить

- added headers to ConsumedMessage - added headers to Envelop - added heartbeat to queue

- added tests

robot-magpie · 2026-04-07T21:23:09Z

Many thanks for the PR! @Malevrovich is now importing your pull request into our internal upstream repository.

robot-magpie · 2026-04-08T14:28:40Z

✅ This pull request is being closed because it has been successfully merged into our internal monorepository.
Your changes will be pushed to this repository soon. Thank you for your contribution!

- Add support for custom message headers - Enable configurable heartbeat interval for connection health checks #137 --- Pull Request resolved: #1129 commit_hash:c4879c75cbdd4d9ba225b84a8d6d13fe20746a58

botanegg reviewed Feb 26, 2026

View reviewed changes

rabbitmq/src/urabbitmq/consumer_base_impl.cpp Outdated Show resolved Hide resolved

Malevrovich requested changes Feb 27, 2026

View reviewed changes

sav-da requested a review from Malevrovich March 1, 2026 18:46

Malevrovich requested changes Mar 2, 2026

View reviewed changes

rabbitmq/src/urabbitmq/component.yaml Outdated Show resolved Hide resolved

sav-da requested a review from Malevrovich March 2, 2026 11:44

Malevrovich requested changes Mar 3, 2026

View reviewed changes

sav-da requested a review from Malevrovich March 4, 2026 06:37

Malevrovich requested changes Mar 4, 2026

View reviewed changes

rabbitmq/include/userver/urabbitmq/client_settings.hpp Outdated Show resolved Hide resolved

sav-da requested a review from Malevrovich March 4, 2026 11:57

Malevrovich requested changes Mar 5, 2026

View reviewed changes

rabbitmq/src/urabbitmq/impl/field_to_string.cpp Outdated Show resolved Hide resolved

rabbitmq/include/userver/urabbitmq/typedefs.hpp Outdated Show resolved Hide resolved

rabbitmq/include/userver/urabbitmq/typedefs.hpp Outdated Show resolved Hide resolved

sav-da requested a review from Malevrovich March 19, 2026 14:17

Malevrovich requested changes Mar 23, 2026

View reviewed changes

Malevrovich requested changes Mar 26, 2026

View reviewed changes

rabbitmq/functional_tests/basic_chaos/tests/test_rabbitmq.py Show resolved Hide resolved

rabbitmq/src/urabbitmq/impl/amqp_connection_handler.cpp Show resolved Hide resolved

sav-da requested a review from Malevrovich April 2, 2026 06:22

Malevrovich requested changes Apr 6, 2026

View reviewed changes

sav-da added 10 commits April 8, 2026 00:04

feat: improved RabbitMQ driver

d23a777

- added headers to ConsumedMessage - added headers to Envelop - added heartbeat to queue

refactor: review points resolved

0d16930

- added tests

fix: fixes after review

4cf229b

fix: fixes after review

7bdba57

fix: fixes after review

591f9ec

refactor: full rework consume message headers

55205bd

refactor: extract AMQP field string conversion helper

4fc56a0

feat: rabbitmq support integral header values in publish

2f17b93

feat: improved rabbitmq headers

3b017e5

fix: fixes after review

8a04765

feat: fix after review

22e03c8

sav-da force-pushed the issue/134 branch from bdb1f44 to 22e03c8 Compare April 7, 2026 21:04

Malevrovich changed the title ~~feat: improved RabbitMQ driver~~ feat rabbitmq: heartbeat and message headers support Apr 7, 2026

Malevrovich approved these changes Apr 7, 2026

View reviewed changes

robot-magpie bot closed this Apr 8, 2026

Conversation

sav-da commented Feb 26, 2026 • edited by Malevrovich Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sav-da commented Mar 4, 2026

Uh oh!

sav-da commented Mar 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sav-da commented Mar 6, 2026

Uh oh!

Malevrovich commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Malevrovich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Malevrovich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Malevrovich left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robot-magpie bot commented Apr 7, 2026

Uh oh!

robot-magpie bot commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sav-da commented Feb 26, 2026 •

edited by Malevrovich

Loading

Malevrovich commented Mar 6, 2026 •

edited

Loading

Malevrovich left a comment •

edited

Loading