feat/refactor: rewrite webhook-handler#3979
Draft
shreddedbacon wants to merge 63 commits intomainfrom
Draft
Conversation
b74f675 to
b7174ed
Compare
4 tasks
b7174ed to
403d0e2
Compare
403d0e2 to
41b97d3
Compare
41b97d3 to
216d5dd
Compare
Overview
Environment Variables (1 changes)
BASH_ENV=/home/.bashrc
ELASTICSEARCH_URL=http://logs-db-service:9200
ENV=/home/.bashrc
HOME=/home
KEYCLOAK_ADMIN_API_CLIENT_SECRET=bb86d344-a52d-11ef-b872-4f4337ee24f0
KEYCLOAK_API_CLIENT_SECRET=39d5282d-3684-4026-b4ed-04bbc034b61a
LAGOON=node
LAGOON_LOCALDEV_HTTP_PORT=3000
LAGOON_VERSION=development
LOGSDB_ADMIN_PASSWORD=admin
NODE_ENV=production
-NODE_VERSION=22.22.0
+NODE_VERSION=22.22.1
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
REDIS_PASSWORD=admin
TMP=/tmp
TMPDIR=/tmp
YARN_VERSION=1.22.22Packages and Vulnerabilities (75 package changes and 7 vulnerability changes)
Changes for packages of type
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Package | Versiontestlagoon/api:main |
Versionlagoon/api:ci-latest |
|
|---|---|---|---|
| ♾️ | node | 22.22.0 |
22.22.1 |
Changes for packages of type golang (1 changes)
| Package | Versiontestlagoon/api:main |
Versionlagoon/api:ci-latest |
|
|---|---|---|---|
| ♾️ | stdlib | 1.25.3 |
1.26.1 |
| Removed vulnerabilities (4): |
|||
Changes for packages of type npm (73 changes)
e18113b to
a1e88cd
Compare
Member
Author
|
I forgot that Edit: Done |
181250f to
0d9f8f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
Description
This is a substantial rewrite of the
webhook-handlerwhich consolidates thewebhook-handlerandwebhooks2tasksservices. Additionally, the API will now call out to theapi-sidecar-handlerservice to handle triggering deployments and environment removals, this allows for shared code between thewebhook-handlerandapi-sidecar-handler.One way this is done is by moving from individual go services with their own go.mod files, into a mono repo setup. There are some remaining services that will need to be converted in a follow up pullrequest though. I left them out of this to try to reduce the amount of changes.
Builds off fork of drone/go-scm, which we can try to get merged into upstream.
Requires uselagoon/lagoon-charts#858