Fix groupByNameAndOrganization resolver errors when group not found#3800
Open
rocketeerbkw wants to merge 1 commit intomainfrom
Open
Fix groupByNameAndOrganization resolver errors when group not found#3800rocketeerbkw wants to merge 1 commit intomainfrom
rocketeerbkw wants to merge 1 commit intomainfrom
Conversation
66d592a to
d7a076f
Compare
Member
|
@rocketeerbkw is this something that needs to be in v2.21.0? |
200e0fd to
52c45e1
Compare
Member
Author
|
This doesn't need to hold up v2.21.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
When attempting to load a group by name and org ID, and the group either doesn't exist, or is not a part of the organization, AND the
membersfield is requested, a cryptic error would be thrown:This is because the resolver returns groupS but the schema expects a single group. Returning an empty array still calls the members resolver, which can't get any information for an
undefinedgroup and fails.This PR changes the return value to be a single group, and throws a normal
GroupNotFoundError.This was broken before the keycloak upgrade refactor but the base branch is that to help with merge conflicts. Can wait to merge after keycloak upgrade.