Merged
Conversation
added 8 commits
February 9, 2026 12:32
…, fix variable shadowing in service-sync, and add a RunSyncProcess debug printer.
CGoodwin90
reviewed
Feb 22, 2026
Contributor
CGoodwin90
left a comment
There was a problem hiding this comment.
Working as expected locally, just noted a couple minor issues.
CGoodwin90
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new way of running a sync. Essentially, it uses the same underlying structure, but it kicks it off in a new way. None of the primary sync logic itself is touched here, it's just how we set it up.
There are several things to pay attention to here - I'll first give a high level overview of the changes in each of the files
sync.go- here I've factored out big chunks of functionality that is to be shared between the oldsynccommand and the newservice-synccommand inserviceSync.gosyncSharedFuncs.gois where the new shared functions existserviceSync.gois the new command. We will speak about this in more detail belowsynchers/syncersFromServiceDefs.gois the set of functions that take in aServicetype (basically something that describes a lagoon service read out of our docker-compose files) and converts it to aSyncerobject type (which tells us stuff like, what commands to run, defaults, etc.) - these functions are all just setup.syncersFromDockerfile.gowill load up and convert a docker compose file into a map ofServicestructs. In the very near future, a similar function will be introduced that can pull these data from the services API.Okay - so what do you need to know about running this?
the new command that's registered is the
service-synccommand. This has several features--all-servicesversion of the sync which is great when you run it in no-interaction mode - this will sync all volumes and services