Skip to content

Added explicit precision for date and time in event bookings #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mitchellkwong wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added explicit precision for date and time in event bookings #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 0 additions & 72 deletions .firebase/hosting.YnVpbGQ.cache
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions src/components/Events/EventForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class EventForm extends Component {
'weeks'
)

if (moment(formApi.getValue('startDate')) > advancedBookingMax) {
if (moment(formApi.getValue('startDate')).isAfter(advancedBookingMax, 'weeks')) {
return (
'Bookings must be made max ' +
maxWeeksInAdvanceForBooking +
Expand All @@ -125,7 +125,9 @@ class EventForm extends Component {
'hours'
)

if (moment(formApi.getValue('endDate')) > endBefore) {
if (moment(formApi.getValue('endDate')).isAfter(endBefore, 'minutes')) {
// console.log(moment(formApi.getValue('endDate')));
// console.log(endBefore);
return 'Max booking duration of ' + maxNoOfHours + ' hours.'
}
}
Expand Down