refactor(unikernels): drop redundant monitor check in Linux block cli formatting

[DevMhrn]

Description

Linux.MonitorBlockCli in pkg/unikontainers/unikernels/linux.go had a dead conditional inside its case "firecracker": switch arm

Since execution only reaches this code when l.Monitor == "firecracker" (picked by the enclosing switch l.Monitor), the inner if is always true and the local id variable is always assigned "FC" + aBlock.ID.

This PR removes the redundant conditional and the unused local , inlining "FC" + aBlock.ID directly into the struct literal matching the inline style used by similar one present case "qemu": arm a few lines above.

Related issues

• Fixes : refactor(unikernels): redundant if l.Monitor == "firecracker" inside firecracker case in Linux.MonitorBlockCli #747

How was this tested?

• Logical equivalence verified by inspection: inside case "firecracker": of switch l.Monitor, l.Monitor == "firecracker" is provably always true and is not mutated inside the loop body, so the rewritten arm produces the same MonitorBlockArgs slice for every input.
• No linux_test.go exists for this unikernel; no test fixture depends on the removed local variable.
• Couldn't invoke make lint directly because the Makefile rejects host arch arm64 (macOS Apple Silicon as, line 39 only knows about Linux aarch64, not macOS arm64). Ran the same golangci-lint v2.7 container the Makefile runs:

  docker run --rm --platform=linux/arm64 -v "$PWD":/app -w /app \
    golangci/golangci-lint:v2.7 golangci-lint run -v --timeout=5m

LLM usage

N/A

Checklist

• I have read the contribution guide.
• The linter passes locally (make lint).
• The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
• If LLMs were used: I have read the llm policy.

[netlify]

✅ Deploy Preview for urunc canceled.

Name	Link
🔨 Latest commit	7f2cd7b
🔍 Latest deploy log	https://app.netlify.com/projects/urunc/deploys/6a2099dc0832dd0008a5bbb7

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Simplifies Firecracker block device ID generation in Linux unikernel monitoring by inlining the "FC" prefix logic.

Changes:

• Removes redundant local id variable and conditional prefixing in the Firecracker monitor case.
• Always sets MonitorBlockArgs.ID to "FC" + aBlock.ID when MonitorBlockCli() is handling the Firecracker branch.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[DevMhrn]

@cmainas ^^, open for your feedback, since it is my very first PR.