refactor: remove unused getInitPid function#534
Open
praffq-dev wants to merge 1 commit intourunc-dev:mainfrom
Open
refactor: remove unused getInitPid function#534praffq-dev wants to merge 1 commit intourunc-dev:mainfrom
praffq-dev wants to merge 1 commit intourunc-dev:mainfrom
Conversation
Remove the dead getInitPid function and its associated tests. Fixes: urunc-dev#466 Signed-off-by: praffq-dev <praffq.dev@gmail.com>
👷 Deploy Preview for urunc processing.
|
✅ Deploy Preview for urunc canceled.
|
Author
|
I'm using MacOs, so not able to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the dead getInitPid function and its associated tests.
Fixes: #466
Description
Remove the unused
getInitPidfunction and related testcasesRelated issues
How was this tested?
getInitPidis not used anywhere, so I rechecked that and remove the code and it's respective test caseLLM usage
No
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).