Open
Conversation
✅ Deploy Preview for urunc canceled.
|
cmainas
force-pushed
the
fix_regexp_in_network_removal
branch
from
83b8fd0 to
e0d07ed
Compare
Fix the regexp that compares the network interfaces names to find urunc tap devices. Make it follow the correct naming convention we use for tap devices in urunc. Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the regexp that compares against the network interfaces to find urunc tap devices. Make it follow the correct naming convention we use for tap devices in urunc.
Related issues
tap*_uruncleft after urunc restart in Kubernetes, preventing NetworkSetup #406How was this tested?
In a k3s environment deployed a urunc container, killed the monitor process and checked if the restarted pod is responsive to network requests.
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).