Skip to content

Apply Benjamini-Hochberg FDR to group correlation stars#10

Closed
urme-b wants to merge 1 commit into
mainfrom
fix/corr-fdr-correction
Closed

Apply Benjamini-Hochberg FDR to group correlation stars#10
urme-b wants to merge 1 commit into
mainfrom
fix/corr-fdr-correction

Conversation

@urme-b

@urme-b urme-b commented Jul 7, 2026

Copy link
Copy Markdown
Owner

The group correlation cell starred 36 pairwise Pearson tests on n=10 with no multiplicity correction. Replaced the raw-p stars with Benjamini-Hochberg FDR q-values over the unique off-diagonal pairs; the diagonal is no longer starred and the title states n and the correction. On the committed data this drops the 'significant' count from 6 to 2 — a more honest picture at this sample size. No new dependency (numpy/scipy only).

Closes #6

@urme-b

urme-b commented Jul 7, 2026

Copy link
Copy Markdown
Owner Author

Superseded: #5 landed its own Benjamini-Hochberg cell (mms.stats.corr_matrix_fdr) on main, so the inline-FDR approach here conflicts and is redundant. The remaining real issue — the old uncorrected-stars cell left behind by #5 — is fixed by removing that cell in the replacement PR.

@urme-b urme-b closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correlation notebook reports significance stars on n=10 without correction

1 participant