Apply Benjamini-Hochberg FDR to group correlation stars#10
Closed
urme-b wants to merge 1 commit into
Closed
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The group correlation cell starred 36 pairwise Pearson tests on n=10 with no multiplicity correction. Replaced the raw-p stars with Benjamini-Hochberg FDR q-values over the unique off-diagonal pairs; the diagonal is no longer starred and the title states n and the correction. On the committed data this drops the 'significant' count from 6 to 2 — a more honest picture at this sample size. No new dependency (numpy/scipy only).
Closes #6