Updated build to use Gradle instead of Maven#24
Open
techbrew-mc wants to merge 1 commit intourgrue:masterfrom
Open
Updated build to use Gradle instead of Maven#24techbrew-mc wants to merge 1 commit intourgrue:masterfrom
techbrew-mc wants to merge 1 commit intourgrue:masterfrom
Conversation
Author
|
I didn't see #20, but I did see the roadmap mention of Gradle. Moreover, the existing maven build doesn't work in jitpack, so perhaps fixing that would be the better compromise: https://jitpack.io/com/github/urgrue/Java-Twitch-Api-Wrapper/0.3/build.log |
|
You're right, it doesn't work with JitPack... I really thought it did... That is definitely something we should strive to fix then. |
|
I've fixed the maven build in #27, just waiting on approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also recommend renaming the repo to "twitch-api-wrapper" to keep consistent with the artifact name.
These changes work nicely with jitpack.io as well: https://jitpack.io/#techbrew-mc/twitch-api-wrapper/0.3.1
(That makes it easy to integrate into other projects without having your releases in Maven Central.)