serf: stay in an inner road between events #540
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runs the serf in an inner road, as long as possible. In practice, the serf will return to the home road to take a snapshot or for
|pack,|meld, and|mass.With this change, all allocations of events and effects no longer modify persistent state. Home-road unification (which we don't have) is somewhat deprioritized, as arvo lives on an inner road between snapshots. On the other hand, with the more efficient free-list utilization from #539, the many small (re)allocations involved in incremental arvo updates should help to defragment the home-road heap.
This PR is a draft because the changes are still somewhat messy, and the error-handling behavior after this change needs to be carefully tested.
This PR should help with urbit/urbit#6805