Remove pointsOwnedBy and related logic #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Contributor
|
Wait what? Can you explain a little moreOn Aug 21, 2024, at 6:20 PM, Calvin McCarter ***@***.***> wrote:
@cgyarvin This fixes #50. Fixing #50 fixes gas costs. Fixing gas costs fixes Azimuth. Fixing Azimuth fixes Urbit. And "Urbit fixes this".
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Author
|
Instead of the naive rollup approach, the original Azimuth contract should've just been made more gas efficient. Implementation changes like this one -- which makes ownership changes less costly, while shifting gas costs to token trackers -- should be tried first. |
Contributor
|
Yep
…On Wed, Aug 21, 2024 at 6:33 PM Calvin McCarter ***@***.***> wrote:
Instead of the naive rollup approach, the original Azimuth contract
should've just been made more gas efficient. Implementation changes like
this one -- which makes ownership changes less costly, while shifting gas
costs to token trackers -- should be tried first.
—
Reply to this email directly, view it on GitHub
<#55 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABPEALF4Q44FPQYIYIXJU3ZSU5W5AVCNFSM6AAAAABM5DNAECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBTGQZTAMZWGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #50 .