Skip to content

Add configurable Zipkin tracing sample rate #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mshivanna wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add configurable Zipkin tracing sample rate #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libats-http-tracing/src/main/resources/reference.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,7 @@ ats {
enabled = ${?ATS_HTTP_TRACING}
zipkin_uri = "http://127.0.0.1:9411"
zipkin_uri = ${?ZIPKIN_URI}
sample_rate = 1.0
sample_rate = ${?ZIPKIN_SAMPLE_RATE}
}
}
5 changes: 3 additions & 2 deletions libats-http-tracing/src/main/scala/com/advancedtelematic/libats/http/tracing/Tracing.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ object Tracing {
try {
if (config.getBoolean("ats.http.tracing.enabled")) {
val uri = Uri(config.getString("ats.http.tracing.zipkin_uri"))
_log.info(s"zipkin tracing enabled to $uri")
ZipkinServerRequestTracing(uri, serviceName)
val sampleRate = config.getDouble("ats.http.tracing.sample_rate").toFloat
_log.info(s"zipkin tracing enabled to $uri with sample rate $sampleRate")
ZipkinServerRequestTracing(uri, serviceName, sampleRate)
} else {
_log.info("Request tracing disabled in config")
new NullTracing
Expand Down
7 changes: 5 additions & 2 deletions ...src/main/scala/com/advancedtelematic/libats/http/tracing/ZipkinServerRequestTracing.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import org.apache.pekko.http.scaladsl.model.{HttpRequest, HttpResponse, Uri}
import org.apache.pekko.http.scaladsl.server.Directive1
import brave.http.{HttpServerAdapter, HttpServerHandler, HttpTracing}
import brave.propagation.TraceContext
import brave.sampler.CountingSampler
import brave.{Span, Tracing => BraveTracing}
import com.advancedtelematic.libats.http.tracing.Tracing.{PekkoHttpClientTracing, ServerRequestTracing, Tracing}
import zipkin2.reporter.AsyncReporter
Expand Down Expand Up @@ -77,13 +78,15 @@ class ZipkinTracing(httpTracing: HttpTracing) extends Tracing {
}

object ZipkinServerRequestTracing {
def apply(uri: Uri, serviceName: String): ZipkinTracing = {
def apply(uri: Uri, serviceName: String, sampleRate: Float = 1.0f): ZipkinTracing = {
val sender = OkHttpSender.create(uri.toString() + "/api/v2/spans")
val spanReporter = AsyncReporter.create(sender)

val tracing = BraveTracing.newBuilder
.localServiceName(serviceName)
.spanReporter(spanReporter).build
.spanReporter(spanReporter)
.sampler(CountingSampler.create(sampleRate))
.build

val httpTracing = HttpTracing.newBuilder(tracing).build()

Expand Down
Loading