Skip to content

fix: prevent fullscreen layout collapse when opening dropdown menus #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CahidArda merged 1 commit into from
Jun 25, 2026
Merged

fix: prevent fullscreen layout collapse when opening dropdown menus #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/components/ui/dropdown-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,15 @@ import { IconCheck, IconChevronRight, IconCircleFilled } from "@tabler/icons-rea
import { portalRoot } from "@/lib/portal-root"
import { cn } from "@/lib/utils"

const DropdownMenu = DropdownMenuPrimitive.Root
// Default to non-modal: modal dropdowns lock scroll via react-remove-scroll, which sets
// `position: relative` on <body>. That breaks consumers (e.g. the console fullscreen view) that
// position a container absolutely against <body>, collapsing its height while the menu is open.
const DropdownMenu = ({
modal = false,
...props
}: React.ComponentProps<typeof DropdownMenuPrimitive.Root>) => (
<DropdownMenuPrimitive.Root modal={modal} {...props} />
)

const DropdownMenuTrigger = DropdownMenuPrimitive.Trigger

Expand Down
Loading