Skip to content

feat: Add arabic langauge#338

Open
Saleh-Alibrahim wants to merge 1 commit into
upjs:mainfrom
Saleh-Alibrahim:feat/arabic
Open

feat: Add arabic langauge#338
Saleh-Alibrahim wants to merge 1 commit into
upjs:mainfrom
Saleh-Alibrahim:feat/arabic

Conversation

@Saleh-Alibrahim
Copy link
Copy Markdown

Add support for arabic langauge

@AliN11
Copy link
Copy Markdown
Collaborator

AliN11 commented Oct 19, 2023

Hey Saleh. Thanks for your contribution. Please consider registering the language in the src/index.ts and src/locales/index.ts files.

Copy link
Copy Markdown

@xJuvi xJuvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the lang var name.

Comment thread src/locales/ar.ts
import * as rules from '@/types/rules';
import { LangKeys } from '@/types';

const enLang: Record<LangKeys, string> = {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also change the lang var name

Comment thread src/locales/ar.ts
[rules.WITHIN]: 'القيمة غير صحيحة',
};

export default enLang;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to the new var name at the file start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants