Make pino a peer dependency#15
Merged
Merged
Conversation
boliveira
previously approved these changes
May 25, 2026
faab109 to
30b718a
Compare
There was a problem hiding this comment.
Pull request overview
This PR changes how pino is consumed by @uphold/debino by moving it from a direct runtime dependency to a peer dependency, and updates docs/lockfiles accordingly so consuming applications explicitly install a compatible pino.
Changes:
- Move
pinofromdependenciestopeerDependencies(^9 || ^10) and add it todevDependenciesfor local development/testing. - Update README installation instructions to include installing
pino. - Regenerate
package-lock.jsonto reflect the dependency graph changes.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Updates install command to include pino. |
| package.json | Makes pino a peer dependency and adds it as a dev dependency. |
| package-lock.json | Updates lockfile to reflect pino moving to dev + peer deps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
30b718a to
30b698c
Compare
boliveira
previously approved these changes
May 25, 2026
30b698c to
5c45674
Compare
boliveira
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main reason for
pinoto be changed to a peer dependency, is to ensure thatpinoinstalled in the project has the same version as the one from this library. This is particularly important if you usesetRootLoggerfor advanced cases wheredestination, and other pino static functions are used during that process:Dependency management:
pinofrom a direct dependency to a peer dependency inpackage.json, allowing users to bring their own compatible version (^9 || ^10).pinotodevDependenciesfor local development and testing.Documentation:
README.mdto instruct users to install both@uphold/debinoandpino.