Skip to content

Make pino a peer dependency#15

Merged
satazor merged 1 commit into
masterfrom
support/make-pino-a-peer-dependency
May 25, 2026
Merged

Make pino a peer dependency#15
satazor merged 1 commit into
masterfrom
support/make-pino-a-peer-dependency

Conversation

@satazor
Copy link
Copy Markdown
Contributor

@satazor satazor commented May 25, 2026

The main reason for pino to be changed to a peer dependency, is to ensure that pino installed in the project has the same version as the one from this library. This is particularly important if you use setRootLogger for advanced cases where destination, and other pino static functions are used during that process:

import { destination, pino } from 'pino';

const stream = destination({ dest: 2 });
const options = {  errorKey: 'error' };

setRootLogger(pino(options, stream));

Dependency management:

  • Changed pino from a direct dependency to a peer dependency in package.json, allowing users to bring their own compatible version (^9 || ^10).
  • Added pino to devDependencies for local development and testing.

Documentation:

  • Updated the installation command in README.md to instruct users to install both @uphold/debino and pino.

Copilot AI review requested due to automatic review settings May 25, 2026 14:52
boliveira
boliveira previously approved these changes May 25, 2026
@satazor satazor force-pushed the support/make-pino-a-peer-dependency branch from faab109 to 30b718a Compare May 25, 2026 14:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes how pino is consumed by @uphold/debino by moving it from a direct runtime dependency to a peer dependency, and updates docs/lockfiles accordingly so consuming applications explicitly install a compatible pino.

Changes:

  • Move pino from dependencies to peerDependencies (^9 || ^10) and add it to devDependencies for local development/testing.
  • Update README installation instructions to include installing pino.
  • Regenerate package-lock.json to reflect the dependency graph changes.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.

File Description
README.md Updates install command to include pino.
package.json Makes pino a peer dependency and adds it as a dev dependency.
package-lock.json Updates lockfile to reflect pino moving to dev + peer deps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment thread package.json
Comment thread package.json
@satazor satazor force-pushed the support/make-pino-a-peer-dependency branch from 30b718a to 30b698c Compare May 25, 2026 14:55
boliveira
boliveira previously approved these changes May 25, 2026
@satazor satazor force-pushed the support/make-pino-a-peer-dependency branch from 30b698c to 5c45674 Compare May 25, 2026 14:58
@satazor satazor merged commit 0141711 into master May 25, 2026
7 checks passed
@satazor satazor deleted the support/make-pino-a-peer-dependency branch May 25, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants