CC-1903/remove-php-8-4-deprecations #214
Conversation
sixer1182
left a comment
sixer1182
left a comment
There was a problem hiding this comment.
There are some nullable params left that are not marked as such.
Also I saw some inconsistancies between method headers and PHP doc tags.
I suggest using AI to improve consistancy and check for missed nullable params.
| /** | ||
| * @param string $tag | ||
| * @param string $ephemeralPublicKey | ||
| * @param string $encryptedMessage |
There was a problem hiding this comment.
PHP doc is not consistant with the allowed parameter types in the method header.
There was a problem hiding this comment.
removed phpdoc, since it only contains redundant information.
| protected $ibanCountry; | ||
|
|
||
| public function __construct(string $ibanCountry = null) | ||
| public function __construct(?string $ibanCountry = null) |
There was a problem hiding this comment.
No function header, no php doc?
There was a problem hiding this comment.
No, since it would not add any actual information.
For general consystancy cleanup i created extra ticket: CC-2652 |
| * @param string|null $uri uri of the target system | ||
| * @param AbstractUnzerResource|null $resource | ||
| * @param string $httpMethod | ||
| * @param string|null $apiVersion |
There was a problem hiding this comment.
didn't run the fixer to make the code more readable?
No description provided.