Skip to content

Conversation

@Ryouzanpaku
Copy link
Contributor

@Ryouzanpaku Ryouzanpaku commented Aug 20, 2025

Also inclueds:

  • CC-2787
  • Some code style fixes fromsonarqube in test classes.
  • Fixes some integration tests that failed before.

@manas-unzer manas-unzer requested a review from Copilot September 8, 2025 07:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements code style improvements based on SonarQube findings and introduces support for Wero payment method including its related models and test coverage.

  • Removes unnecessary public modifiers from test class and method declarations (JUnit 5 package visibility)
  • Replaces wildcard imports with explicit import statements for better code clarity
  • Adds Wero payment type support with EventDependentPayment configuration and comprehensive test coverage

Reviewed Changes

Copilot reviewed 81 out of 81 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Test classes (multiple) Removed public modifiers from test classes and methods, replaced wildcard imports with explicit imports
WeroTest.java Added comprehensive test coverage for new Wero payment type including charge, authorize, and additional transaction data scenarios
AdditionalTransactionDataWeroTest.java Added unit tests for Wero-specific additional transaction data serialization and deserialization
PaypageV2Test.java Extended PaypageV2 tests to include Wero payment method configurations with EventDependentPayment support
ApiConfigTest.java Updated test base URL for paypage service from unzer.io to unzer.com
TokenServiceTest.java Moved from service package to integration package
AbstractPaymentTest.java Updated test customer data (email and shipping address)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@sixer1182 sixer1182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the following:

  • My comments
  • Comments by Copilot
  • failing tests

To avoid extensive and unrelated changes in the same branch we should next time create a second task and branch e.g. for the test updates in this case. This was really hard to review.

@Ryouzanpaku Ryouzanpaku merged commit 7cb55df into main Sep 24, 2025
2 of 5 checks passed
@Ryouzanpaku Ryouzanpaku deleted the CC-2673/add-wero branch September 24, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants