Fix: Avoid duplicate neighbor slots in HNSW reverse links#699
Merged
ashvardanian merged 3 commits intounum-cloud:main-devfrom Mar 2, 2026
Merged
Fix: Avoid duplicate neighbor slots in HNSW reverse links#699ashvardanian merged 3 commits intounum-cloud:main-devfrom
ashvardanian merged 3 commits intounum-cloud:main-devfrom
Conversation
yoonseok-kim
force-pushed
the
issue-698-bugfix
branch
from
52bbcee to
d1f4061
Compare
3 tasks
Contributor
Author
|
I understand this problem may not be a critical issue, but I think it could be considered a bug. I would appreciate it if you could review whether it might be possible to address this in next release. If this PR is merged, it would benefit our product. Thank you for your consideration. :) |
Contributor
|
Hi @yoonseok-kim! Shouldn't we instead use |
Contributor
Author
|
Good point. thanks! I’ll apply it. |
…k in index_gt::form_reverse_links_
yoonseok-kim
commented
Feb 23, 2026
Contributor
Author
|
I would appreciate it if you could review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #698.