Merged
Conversation
According to https://eel.is/c++draft/lex.name#3, symbols that include double underscores and symbols in the global namespace that start with an underscore are "reserved for use by C++ implementations and shall not be used otherwise". As I understand the standards, that means it's technically UB to use such symbols. This change renames the symbol to a legal one.
In both `load_from_stream` and `view`, we initialize `cast_buffer_` to hold enough slots for a certain number of threads. This number of threads is currently `available_threads_.size()`. However, `available_threads_` gets replaced later in both methods, specifically updating the number of threads to `old_limits.threads()`. This change makes the initialization statement use that value instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.