-
Notifications
You must be signed in to change notification settings - Fork 84
feat: add stub page for Tailscale plugin #2497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Derek Kaser <11674153+dkaser@users.noreply.github.com>
WalkthroughA new Unraid Dynamix web UI page for Tailscale plugin installation is introduced. The page provides menu metadata, includes JavaScript for plugin installation via the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
emhttp/plugins/dynamix/Tailscale.page (1)
6-7: Consider updating copyright years.The copyright notice mentions 2023, but the current year is 2025. Consider updating to reflect the current year.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
emhttp/plugins/dynamix/images/tailscale.pngis excluded by!**/*.png
📒 Files selected for processing (1)
emhttp/plugins/dynamix/Tailscale.page
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Squidly271
Repo: unraid/webgui PR: 0
File: :0-0
Timestamp: 2025-09-20T22:25:36.654Z
Learning: In the unraid/webgui project, the `.tabs-container` element is always present in the DOM for the plugins page, making it a reliable target for DOM manipulation.
Learnt from: elibosley
Repo: unraid/webgui PR: 2189
File: emhttp/plugins/dynamix/LogViewer.page:6-8
Timestamp: 2025-05-09T15:13:07.361Z
Learning: The <unraid-log-viewer> custom element will be provided by the Unraid API repository (https://github.com/unraid/api) and is not yet included in Unraid OS. The emhttp/plugins/dynamix/LogViewer.page file is preparing the UI for this upcoming integration.
📚 Learning: 2025-03-27T22:04:34.550Z
Learnt from: zackspear
Repo: unraid/webgui PR: 2099
File: emhttp/plugins/dynamix.my.servers/include/web-components-extractor.php:13-19
Timestamp: 2025-03-27T22:04:34.550Z
Learning: The file emhttp/plugins/dynamix.my.servers/include/web-components-extractor.php is synced from another repository and should not be modified directly in the webgui repository.
Applied to files:
emhttp/plugins/dynamix/Tailscale.page
🔇 Additional comments (3)
emhttp/plugins/dynamix/Tailscale.page (3)
17-21: VerifyopenPluginfunction availability and parameter usage.The
openPluginfunction is called but not defined in this file. Ensure it's globally available in the Unraid framework and that the parameters are correctly specified.
2-2: Verify that the icon file exists.The page references
Icon="tailscale.png"but this file is not included in the PR. Ensure the icon file exists in the appropriate location (typically in the icons directory) or is provided separately.
25-32: All form patterns are consistent with framework conventions. Themarkdown="1"attribute is a standard Unraid feature used throughout the plugin pages;target="progressFrame"is the standard pattern for form submissions across dynamix; and theca.unraid.net/dl/proxy pattern is replicated identically in the Apps.page plugin installation form.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.