Skip to content

Conversation

@SimonFair
Copy link
Contributor

@SimonFair SimonFair commented Mar 8, 2022

Initial code for 6.10+

@SimonFair SimonFair marked this pull request as draft March 8, 2022 20:25
@SimonFair SimonFair changed the title Initial Commit for Mover Status rc3+ Add Mover Status rc3+ Mar 8, 2022
@SimonFair
Copy link
Contributor Author

SimonFair commented Mar 9, 2022

Example View

image

@bergware
Copy link
Contributor

Very nice!
I like it.

@SimonFair SimonFair marked this pull request as ready for review March 20, 2022 11:05
@SimonFair
Copy link
Contributor Author

SimonFair commented Mar 20, 2022

@limetech these changes will be pending your mover and move changes needed to made mover.ini in state dir.

@SimonFair
Copy link
Contributor Author

SimonFair commented Apr 2, 2022

Gist for my current test mover script https://gist.github.com/SimonFair/91d54c983a8c9b09c0d803baa25f01ac

@SimonFair SimonFair closed this May 9, 2022
@SimonFair SimonFair reopened this May 26, 2022
@limetech
Copy link
Contributor

it's baaaaaaaaaaack

@SimonFair
Copy link
Contributor Author

SimonFair commented Jun 2, 2022

@limetech Started creating a php version of the mover script to allow status to show file name and current action. But I still need to look at is the progress for each file. Can you provide details of now to get the ioctl from move so I can update the nchan for parity_list to get the progress. Or if you have another way you would like to progress let me know.

WIP https://gist.github.com/SimonFair/5e1f318b20e43afc01dcf29a78aee2c1

image
image
image

@SimonFair SimonFair changed the title Add Mover Status rc3+ Add Mover Status 6.10 Jun 5, 2022
@LoveBootCaptain
Copy link

any info from @limetech when or if this PR get merged?

@chrisallen
Copy link

chrisallen commented Dec 16, 2022

Wow this looks amazing!

@okiyama
Copy link

okiyama commented Jul 20, 2023

Bump, this would be a great feature

@Joly0
Copy link

Joly0 commented Nov 24, 2023

Any news on this one?

@SimonFair SimonFair changed the title Add Mover Status 6.10 Add Mover Status 6.13 Nov 26, 2023
@SimonFair
Copy link
Contributor Author

@limetech I have update the processing to allow lines to be hidden, i.e. file being changed.

writestatus() {
echo "TotalToArray=${TOTALTO}" > $MOVERSTATUS
echo "RemainToArray=${TO}" >> $MOVERSTATUS
echo "TotalFromArray=${TOTALFROM}" >> $MOVERSTATUS
echo "RemainFromArray=${FROM}" >> $MOVERSTATUS
echo "File=" >> $MOVERSTATUS
echo "Action=Moving share ${SHARE}" >> $MOVERSTATUS
echo "Filepercent=" >> $MOVERSTATUS
echo "Showlines=5" >> $MOVERSTATUS
echo "Selectlines=2,3,4,5" >> $MOVERSTATUS
echo "movertitle1=File being processed:" >> $MOVERSTATUS
echo "movertitle2=Action:" >> $MOVERSTATUS
echo "movertitle3=Progress:" >> $MOVERSTATUS
echo "movertitle4=Transfering To Array:" >> $MOVERSTATUS
echo "movertitle5=Transfering From Array:" >> $MOVERSTATUS
}

@JanEisen
Copy link

why is this not being merged? would be so great to have!

@nebb00
Copy link

nebb00 commented Jul 4, 2024

is it possible to have this notify the apprise api of its progress ?

@Joly0
Copy link

Joly0 commented Dec 12, 2024

Is there any reason, why this hasnt been merged yet? Would love to see this feature implemented in unraid 7.1

@skycryer
Copy link

Can someone solve the conflicts and merge it into 7 please?

@SimonFair
Copy link
Contributor Author

Can someone solve the conflicts and merge it into 7 please?

Unlikely at this point as backend changes are required for pool to pool and progress. These are just the GUI changes.

@ljm42 ljm42 added the TBD label Apr 29, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 29, 2025

Warning

Rate limit exceeded

@ljm42 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 33 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4be462d and 7d08940.

📒 Files selected for processing (6)
  • emhttp/languages/en_US/helptext.txt (1 hunks)
  • emhttp/plugins/dynamix/ArrayOperation.page (7 hunks)
  • emhttp/plugins/dynamix/MoverSettings.page (1 hunks)
  • emhttp/plugins/dynamix/nchan/parity_list (3 hunks)
  • sbin/moverprogress (1 hunks)
  • sbin/moverprogressB (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@johntdyer
Copy link

Really hoping this makes it in soon, seems like a great addition with most of the heavy lifting already done

@RobertCajun
Copy link

Can we potentially get an update on this?

@kronflux
Copy link

kronflux commented Sep 8, 2025

+1 for this, this would be fantastic

@omarahmed786
Copy link

Would love this to be added soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.