fix: stale dark class theme bootstrap#2006
Open
elibosley wants to merge 1 commit into
Open
Conversation
Purpose of the change: - Make the web theme bootstrap remove stale dark classes when the server only provides --theme-dark-mode: 0. How behavior was before: - When --theme-name was unavailable, bootstrap only added dark if dark mode was detected. - A stale html/body dark class could remain even while --theme-dark-mode was 0. Why that was a problem: - Light Unraid themes could still render Tailwind dark styles after a stale class survived on the page root. What the new change accomplishes: - Treats the computed dark-mode state as authoritative in the fallback path and reconciles both add and remove cases. - Adds regression coverage for a light CSS variable with stale dark classes. How it works: - Reuses applyDarkClass(isDarkModeActive(), darkMode) when --theme-name is missing so the existing sync path updates html, body, .unapi, and the store state together.
Contributor
WalkthroughThis PR refactors dark-mode initialization in the theme store by removing an internal helper function and directly calling ChangesDark Mode Initialization
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2006 +/- ##
==========================================
- Coverage 52.59% 52.58% -0.01%
==========================================
Files 1033 1033
Lines 71682 71676 -6
Branches 8181 8176 -5
==========================================
- Hits 37698 37688 -10
- Misses 33858 33862 +4
Partials 126 126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This plugin has been deployed to Cloudflare R2 and is available for testing. |
elibosley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.darkclasses from the computed dark-mode state when--theme-nameis unavailable.--theme-dark-mode: 0is present but staledarkclasses remain.Root Cause
The previous fallback bootstrap path only added
darkwhen dark mode was detected. If--theme-namewas missing and the DOM already had staledarkclasses,--theme-dark-mode: 0was not enough to actively remove them.Impact
Light Unraid themes can no longer keep Tailwind dark styles active just because a stale
darkclass survived on<html>,<body>, or.unapicontainers.Verification
pnpm exec eslint src/store/theme.ts __test__/store/theme.test.tsNote:
pnpm exec vitest run __test__/store/theme.test.tsis currently blocked before test collection by the existing Vue devtools / localStorage test-environment failure:localStorage.getItem is not a function.Summary by CodeRabbit
Tests
Refactor