NeuralForecastModel example notebook#3026
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@daidahao I created the example notebook for |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3026 +/- ##
==========================================
- Coverage 95.73% 95.66% -0.07%
==========================================
Files 158 158
Lines 17122 17122
==========================================
- Hits 16391 16380 -11
- Misses 731 742 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dennisbader |
|
View / edit / reply to this conversation on ReviewNB jakubchlapek commented on 2026-02-23T11:04:21Z Line #18. fig = pred_prob.plotly(label="KAN (probabilistic)", fig=fig) when i loaded the notebook locally the plot was squashed by the too long labels. maybe we can do `label="KAN (probabilistic)<br>", should solve this issue without any other issues. |
|
View / edit / reply to this conversation on ReviewNB jakubchlapek commented on 2026-02-23T11:04:22Z
|
|
View / edit / reply to this conversation on ReviewNB jakubchlapek commented on 2026-02-23T11:04:23Z Line #13. # finally, apply a MinMax scaler to scale all values into the range (0,1) it was scaled before on line #6, maybe just comment with |
|
View / edit / reply to this conversation on ReviewNB jakubchlapek commented on 2026-02-23T11:04:23Z Line #5. pred = model_nf.fit(series_multivar[:-12]).predict(n=output_chunk_length) could use |
|
View / edit / reply to this conversation on ReviewNB jakubchlapek commented on 2026-02-23T11:04:24Z should be #7 |
|
hey @dennisbader, pretty much LGTM, some very very minor corrections, mostly out of personal preference lol. I like the plots with the direct comparisons between the models, as well as the covariate forecasting sections. It really shows how nice of a feature NF support is :) |
|
@dennisbader
The reason I want to move Probabilistic Forecasting and Comparison at the end is because 1) probabilistic forecasting is visually different than all deterministic forecasting before and 2) the validation (Darts vs NF) might be more academic driven than being directly helpful to users. Other than that, I think the PR is almost merge-ready. |
|
Thanks for the review @daidahao, the suggestions make a lot of sense :) I updated the notebook 🚀 |
Sad to see the |
|
Thanks @daidahao :) Yes, unfortunately when rendering the notebooks with nbshinx during docs generation, the plotly figures either didn't show up in the HTML or source notebooks. Thought it was easiest to rollback to static images. |
Checklist before merging this PR:
Summary
Adds NeuralForecastModel example notebook.