test: 100% library coverage + Codecov OIDC fix#4
Merged
Conversation
- Add exhaustive tests for isExtendedPictographic (all Unicode ranges) - Add direct unit tests for asciiWidth (SWAR fast/slow paths, control chars) - Add StringWidth ASCII control character delegation tests - Fix Codecov: file → files (v5), use OIDC auth (no token needed) - Update README and CHANGELOG with 100% coverage
Library Comparison
Raw benchmark output
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Regression DetectionComparing Summary: Full benchstat output |
rune is int32; valid Unicode codepoints (0–0x10FFFF) are always non-negative, so uint32 conversion cannot overflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests added
TestIsExtendedPictographic_AllRanges— all 8 range branches + switch + negativesTestAsciiWidth— empty string, SWAR fast/slow paths, control chars, scalar tailTestAsciiWidth_SWARControlAtEveryPosition— control at each byte offset in 8-byte chunkTestStringWidth_ASCIIControlMix— end-to-end ASCII with control charactersCodecov fix
file:→files:(v5 breaking change, old param was silently ignored)use_oidc: true+id-token: writepermission (no secret needed)Test plan
go test -cover→ 100.0% of statements