Remove wallet migrate + legacy import (companion to sphere-sdk#655)#53
Merged
Merged
Conversation
…ort dependency
Companion PR to sphere-sdk#655 (wave 6-P2-19) which deletes the legacy
v1 import path entirely per user directive "No v1 backward compatibility!".
Removals from src/legacy/legacy-cli.ts:
- `import { importLegacyTokens } from '@unicitylabs/sphere-sdk/profile'`
— the deleted SDK export
- `case 'migrate':` handler (~186 LoC) — the imperative migrate command
- `'wallet migrate':` help-table entry
- Migration hint block at legacy-wallet detection ("Legacy wallet
detected at ... — run: sphere wallet migrate")
- 'migrate' entry in the wallet subcommand list
Rationale: v1 aggregator is retired; v1 wallets can no longer transact.
Rather than keep an import path that reads dead-format data, delete it
entirely and rebuild any migration flow as a first-class import if the
need arises again.
Must land BEFORE sphere-sdk#655 or the CLI blows up at boot with
`SyntaxError: does not provide an export named 'importLegacyTokens'`.
Build: `npm run build` clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to sphere-sdk#655 (wave 6-P2-19 v1-purge).
sphere-sdk deleted the
importLegacyTokensexport. Without this CLI companion PR merged FIRST, sphere-cli blows up at boot:Removed the legacy migrate subcommand + import + migration-hint block. Build passes.