Conversation
TeddyRoncin
reviewed
Nov 6, 2024
| </p> | ||
| )} | ||
| <div className={styles.meta}> | ||
| {!comment.isAnonymous && ( |
Member
There was a problem hiding this comment.
si l'utilisateur est anonyme, c'est pas possible de quand même mettre une icone user mais où c'est marqué anonyme et sans lien dessus ? (ou même une icone anonymous 👀) (en fait je pensais à un truc mais c'est ptet pas anonymous)
Dans l'idée, ya probablement mieux mais pour visualiser :
| <div> | ||
| <div>{t('ues:detailed.comments.writtenDate', { date: comment.createdAt.toLocaleDateString() })}</div> | ||
| {comment.updatedAt && ( | ||
| <div>{t('ues:detailed.comments.updatedAt', { date: comment.updatedAt.toLocaleDateString() })}</div> |
Member
There was a problem hiding this comment.
une icone clock pour chacune des 2 ça serait mieux je pense, ça fait bizarre de pas avoir d'icone à côté de updatedAt
| t('ues:detailed.noWorkingTimeInfo') | ||
| )} | ||
| </div> | ||
| </div> | ||
| <div className={styles.divider} /> | ||
| {!isAnnalUploaderOpen ? ( |
Member
There was a problem hiding this comment.
c'est giga long comme ternaire, ça serait cool de la diviser, limite dans le même fichier si tu veux mais là c'est dur de retrouver les séparations de la ternaire (début, milieu et fin)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+10
to
+27
| runs-on: self-hosted | ||
| strategy: | ||
| matrix: | ||
| node-version: [18] | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 9 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: 'pnpm' | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm lint | ||
|
|
||
| deploy-dev: |
Comment on lines
+28
to
+56
| if: ${{ github.event_name != 'pull_request' && (github.ref == 'refs/heads/dev') }} | ||
| runs-on: self-hosted | ||
| needs: | ||
| - lint | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Install docker | ||
| uses: docker/setup-buildx-action@v3 | ||
| - name: Login to registry | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: ${{ secrets.REGISTRY_URL }} | ||
| username: ${{ secrets.REGISTRY_USERNAME }} | ||
| password: ${{ secrets.REGISTRY_TOKEN }} | ||
| - run: cp .env.dist .env.prod | ||
| - name: Build and push | ||
| uses: docker/build-push-action@v6 | ||
| with: | ||
| push: true | ||
| build-args: | | ||
| NODE_ENV=production | ||
| NEXT_PUBLIC_API_URL=https://etu.dev.uttnetgroup.fr/api | ||
| NEXT_PUBLIC_CAS_SERVICE_URL=https://etu.utt.fr/login | ||
| NEXT_PUBLIC_API_VERSION=v1 | ||
| NEXT_PUBLIC_API_REQUEST_TIMEOUT=5000 | ||
| tags: | | ||
| ${{ secrets.REGISTRY_URL }}/etuutt/front:dev | ||
|
|
||
| deploy-prod: |
Comment on lines
+57
to
+83
| if: ${{ github.event_name != 'pull_request' && (github.ref == 'refs/heads/master') }} | ||
| runs-on: self-hosted | ||
| needs: | ||
| - lint | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Install docker | ||
| uses: docker/setup-buildx-action@v3 | ||
| - name: Login to registry | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: ${{ secrets.REGISTRY_URL }} | ||
| username: ${{ secrets.REGISTRY_USERNAME }} | ||
| password: ${{ secrets.REGISTRY_TOKEN }} | ||
| - run: cp .env.dist .env.prod | ||
| - name: Build and push | ||
| uses: docker/build-push-action@v6 | ||
| with: | ||
| push: true | ||
| build-args: | | ||
| NODE_ENV=production | ||
| NEXT_PUBLIC_API_URL=https://etu.utt.fr/api | ||
| NEXT_PUBLIC_CAS_SERVICE_URL=https://etu.utt.fr/login | ||
| NEXT_PUBLIC_API_VERSION=v1 | ||
| NEXT_PUBLIC_API_REQUEST_TIMEOUT=5000 | ||
| tags: | | ||
| ${{ secrets.REGISTRY_URL }}/etuutt/front:prod |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.