Skip to content

fix: serialize an Invalid Date instead of throwing #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WebReflection merged 1 commit into from
Jun 23, 2026
Merged

fix: serialize an Invalid Date instead of throwing #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cjs/serialize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ const serializer = (strict, json, $, _) => {
return index;
}
case DATE:
return as([TYPE, value.toISOString()], value);
return as([TYPE, isNaN(value.getTime()) ? EMPTY : value.toISOString()], value);
case REGEXP: {
const {source, flags} = value;
return as([TYPE, {source, flags}], value);
Expand Down
2 changes: 1 addition & 1 deletion esm/serialize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ const serializer = (strict, json, $, _) => {
return index;
}
case DATE:
return as([TYPE, value.toISOString()], value);
return as([TYPE, isNaN(value.getTime()) ? EMPTY : value.toISOString()], value);
case REGEXP: {
const {source, flags} = value;
return as([TYPE, {source, flags}], value);
Expand Down
9 changes: 9 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,4 +159,13 @@ assert(lossy2[3].size, 0);
assert(JSON.stringify(lossy2[4]), '{}');
assert(lossy2[5], 'OK');

// an Invalid Date must round-trip like native structuredClone instead of throwing
const invalidDate = new Date(NaN);
const invalidViaRecord = deserialize(serialize(invalidDate));
assert(invalidViaRecord instanceof Date, true);
assert(Number.isNaN(invalidViaRecord.getTime()), true);
const invalidViaJSON = parse(stringify(invalidDate));
assert(invalidViaJSON instanceof Date, true);
assert(Number.isNaN(invalidViaJSON.getTime()), true);

require('./eval.js');
Loading