This repository was archived by the owner on Dec 5, 2023. It is now read-only.
Make Language data exportable#633
Open
vleong2332 wants to merge 1 commit intounfoldingWord-dev:developfrom
Open
Make Language data exportable#633vleong2332 wants to merge 1 commit intounfoldingWord-dev:developfrom
vleong2332 wants to merge 1 commit intounfoldingWord-dev:developfrom
Conversation
Contributor
|
If it's a long running function, perhaps you should kick off another process that creates the export file, and return a page that tells the user he will receive an email with a link when the export is complete. Reviewed 1 of 1 files at r1. Comments from Reviewable |
Contributor
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. td/admin.py, line 55 at r1 (raw file):
See comment above. Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export may not work properly in prod because it took longer than 30 seconds to complete.
This change is