chore(deps): bump undici from 6.23.0 to 7.22.0#12
Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
Closed
chore(deps): bump undici from 6.23.0 to 7.22.0#12dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Bumps [undici](https://github.com/nodejs/undici) from 6.23.0 to 7.22.0. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.23.0...v7.22.0) --- updated-dependencies: - dependency-name: undici dependency-version: 7.22.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| "@toon-format/toon": "^2.1.0", | ||
| "commander": "^12.1.0", | ||
| "undici": "^6.21.0", | ||
| "undici": "^7.22.0", |
There was a problem hiding this comment.
Bug: The uploadBackup function uses the native FormData object, which is incompatible with undici v7, causing uploads to fail.
Severity: HIGH
Suggested Fix
Import FormData and Blob from the undici package instead of relying on the native global versions. Use these imported classes to construct the request body within the uploadBackup function to ensure compatibility with undici v7.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L55
Potential issue: The `uploadBackup` function in `src/api/system.ts` constructs a request
body using the native Node.js `FormData` and `Blob` objects. However, the project's
updated `undici` v7 dependency no longer supports third-party `FormData`
implementations. It requires using the `FormData` and `Blob` classes exported directly
from the `undici` package. The current implementation, which casts the request body as
`any`, will cause the backup upload request to fail at runtime because
`undici.request()` will not be able to process the native `FormData` object.
Did we get this right? 👍 / 👎 to inform future reviews.
Author
|
Superseded by #14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps undici from 6.23.0 to 7.22.0.
Release notes
Sourced from undici's releases.
... (truncated)
Commits
0a23610Bumped v7.22.0 (#4829)f3c5c61feat: Support async cache stores in revalidation (#4826)9b78a44fix(deduplicate): avoid deduping methods not in methods option (#4818)0ce57babuild(deps-dev): bump esbuild from 0.25.12 to 0.27.3 (#4821)2453caffix: route websocket upgrades through new handler API (#4787)4658cdffeat(dispatcher/env-http-proxy-agent): strip leading dot and asterisk (#4676)a821c56fix: use OR operator in includesCredentials per WHATWG URL Standard (#4816)b3326b5docs: fix syntax highlighting in WebSocket.md (#4814)393c0daBumped v7.21.0 (#4813)47f9b96fix: set finalizer only for fetch responses (#4803)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)