Add a validation requests controller to bops_preapps#2755
Closed
Add a validation requests controller to bops_preapps#2755
Conversation
pixeltrix
force-pushed
the
add-preapps-validation-requests-controller
branch
from
3370920 to
118e396
Compare
pixeltrix
commented
Dec 19, 2025
Member
Author
pixeltrix
left a comment
pixeltrix
left a comment
There was a problem hiding this comment.
This is just for 'other change' validation requests - will add others later today.
|
|
||
| def set_planning_application | ||
| scope = current_local_authority.planning_applications | ||
| planning_application = scope.find_by!(reference: params[:reference]) |
Member
Author
There was a problem hiding this comment.
We need to fix everywhere else we're doing the following:
PlanningApplication.find_by(reference: params[:reference])Because that reference is not globally unique - needs to be scoped to the local authority.
| <% else %> | ||
| <p>Applicant has not responded yet</p> | ||
| <% end %> | ||
| </div> |
Member
Author
There was a problem hiding this comment.
Currently this block is hidden unless the planning application is in an invalidated state - seems like you'd want to see the applicant response even after the application has been validated so I've removed the condition.
All the redirect_to/return_to handling was becoming unmanageable.
pixeltrix
force-pushed
the
add-preapps-validation-requests-controller
branch
from
118e396 to
96ae49b
Compare
benbaumann95
approved these changes
Dec 19, 2025
Member
Author
|
Closing because it's out of date and we have copied chunks across |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the redirect_to/return_to handling was becoming unmanageable.