upload

[michaelmattig]

No description provided.

[michaelmattig]

Dataset importieren, z.B. geosjon, geodb

[ChristianBeilschmidt]

The core doesn't build, it says:

Compiling TypeScript sources through ngc
ERROR: projects/wave-core-new/src/lib/datasets/dataset.service.ts:27:58 - error TS2304: Cannot find name 'DataSetIdDict'.

27 createDataSet(create: CreateDataSetDict): Observable {

Unfortunately, our core-new is not part of our CI-build-run. Maybe you can add it to package.json > build ?

[michaelmattig]

The core doesn't build, it says:

Compiling TypeScript sources through ngc
ERROR: projects/wave-core-new/src/lib/datasets/dataset.service.ts:27:58 - error TS2304: Cannot find name 'DataSetIdDict'.
27 createDataSet(create: CreateDataSetDict): Observable {

Unfortunately, our core-new is not part of our CI-build-run. Maybe you can add it to package.json > build ?

a8cbb47

[ChristianBeilschmidt]

1. 

• I don't know why there is a card, but this doesn't look any good. You could just remove it.
• Upload and Browse are not aligned or the area is not separated such that it looks harmonical.
• Couldn't we have some drag and drop instead?
  • this could also solve the problem that I can't see which files are selected after I selected them.

2. 

• After upload, I have no clue which files were uploaded but I have to name a file.
• The box below should have scrollbars and not the dialog window. It looks broken.
• When I click at "create dataset", nothing happens, and then there is "Upload successful" at some point.
• After "Upload successful", I have no clue where my file is, I guess I found it at "data sets". We could, for instance, add it as a layer.
• The dataset crashed after trying to add it with NULL-ptr from GDAL. Couldn't we try to load it to ensure it works?
• The name of the dataset was the one from the example, but I had no means to change the name. I changed the name and description in the JSON box, but it seems to have no effect.

3. A good general idea would be to let a user define the main file of upload and then retrieve as much metadata as possible from it.

[michaelmattig]

* I don't know why there is a card, but this doesn't look any good. You could just remove it.

the process consists of multiple steps, each step is a card. As inputing raw loading info is not user friendly we will rework this dialog anyway.

* Upload and Browse are not aligned or the area is not separated such that it looks harmonical.
* Couldn't we have some drag and drop instead?
  * this could also solve the problem that I can't see which files are selected after I selected them.

Yeah the "browse" is not a button but a file-input which looks different in every browser and for each language. This needs a separate component. may be a good hiwi-task

* After upload, I have no clue which files were uploaded but I have to name a file.

we won't ever ask the user to input the raw loading info. We will have to implement custom dialogs for different types of upload. But this is not in the scope of this task

* The box below should have scrollbars and not the dialog window. It looks broken.

The textbox will never be user by real users so no need to style it. In my browser it looks fine ;)

* When I click at "create dataset", nothing happens, and then there is "Upload successful" at some point.

should happen instantaneously. Do we have loading indicators for create layer buttons (aside from the layer list)?

* After "Upload successful", I have no clue where my file is, I guess I found it at "data sets". We could, for instance, add it as a layer.

Yeah I thought about showing a "add data set to map" button after the data set was created. But I guess in reality you want to go to the "Add data" menu automatically and highlight the new dataset there. But this I cannot do yet and is outside of the scope of the task

* The dataset crashed after trying to add it with NULL-ptr from GDAL. Couldn't we try to load it to ensure it works?

It worked for ports and NDVI for me. There are many pitfalls when specifying the loading info directly. So maybe try them or give me the data you used and I can look at the problem..

* The name of the dataset was the one from the example, but I had no means to change the name. I changed the name and description in the JSON box, but it seems to have no effect.

it takes the name in the json and worked for me... please give me the data so I can reproduce it

1. A good general idea would be to let a user define the main file of upload and then retrieve as much metadata as possible from it.

Nice idea. Could be the next task in the story.

[michaelmattig]

I added a loading indicator and fixed the layout a bit ed83aa3
I fixed the loading info data binding and your data set works now 9801b46