Ground station relay

[settwi]

No description provided.

[settwi]

@masek014 do you want to make changes before merging?

[masek014]

@masek014 do you want to make changes before merging?

Yes let's wait to merge this one

[masek014]

Should we address #40 before merging?

[settwi]

did you already make the change from that issue in the branch? just change it here and add “fixes [num]40”

[settwi]

it looks like the code references GROUND_STATION_PORT which is undefined

[masek014]

it looks like the code references GROUND_STATION_PORT which is undefined

Yeah this is defined in a file in the home directory not tracked in the repo because I don't want to expose the ground station IP ;)

[masek014]

I am happy with this now; we can merge if you're also happy @settwi

[settwi]

do you need to put variables in curly braces for systemd?

[masek014]

do you need to put variables in curly braces for systemd?

Looks like you don't _have_to, but I just checked and ${GROUNDSTATION_IP}:${GROUNDSTATION_PORT} evaluated differently (and broke) without the curly braces

[settwi]

strange

[masek014]

I made this branch, so my review is: "GOOD!"

... however, do we want to merge this into main or monitor? It is originally branched off of monitor...

[settwi]

I would like to replace the relay logic with a udp capture. i can work on that, or you can

[masek014]

I think the new stuff with udpcapture is good. However, do we wanna merge this branch into main or monitor? relay branched from monitor...

[settwi]

I'm going to merge this to main and delete the two branches. For other updates to the monitor, start a new branch

[masek014]

I'm going to merge this to main and delete the two branches. For other updates to the monitor, start a new branch

Oh there will definitely be another branch... many unpushed changes remain on the ground station