-
-
Notifications
You must be signed in to change notification settings - Fork 10
feat: Add .lycheeignore to exclude specific github author URLs from link checks. #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Onuralp SEZER <onuralp@ultralytics.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
π Hello @onuralpszr, thank you for submitting a -β
Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions. For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! π |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π PR Review
Made with β€οΈ by Ultralytics Actions
Clean addition overall: a dedicated .lycheeignore with clear inline guidance reduces noisy link-check failures and is easy to maintain. The only issue is the GitHub avatar ignore pattern being overly narrow; widening it will make the ignore robust to common query-string variants and avoid future CI regressions.
π¬ Posted 1 inline comment
|
cc @glenn-jocher friendly ping for review for fixing author URL problem. |
|
Merged β huge thanks @onuralpszr for this thoughtful improvement, and appreciation to @glenn-jocher for the support and collaboration on it. π As Benjamin Franklin put it, βAn ounce of prevention is worth a pound of cure.β This PR nails that idea: adding Thanks again for making the docs pipeline more reliable for everyone contributing to Ultralytics. |
π οΈ PR Summary
Made with β€οΈ by Ultralytics Actions
π Summary
Adds a Lychee ignore list to skip known-problematic links during docs link checking πβ
π Key Changes
.lycheeignorefile to configure Lycheeβs link checker exclusions π§Ύπ― Purpose & Impact