Convert impurity radiation data structure to dataclass#4264
Open
timothy-nunn wants to merge 1 commit into
Open
Convert impurity radiation data structure to dataclass#4264timothy-nunn wants to merge 1 commit into
timothy-nunn wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4264 +/- ##
==========================================
- Coverage 50.13% 50.12% -0.01%
==========================================
Files 151 151
Lines 29343 29333 -10
==========================================
- Hits 14710 14703 -7
+ Misses 14633 14630 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
force-pushed
the
impurity-radiation-dataclass
branch
from
0a3f3ec to
72e3ee7
Compare
timothy-nunn
force-pushed
the
impurity-radiation-dataclass
branch
from
72e3ee7 to
0d4677c
Compare
clmould
requested changes
May 20, 2026
Collaborator
There was a problem hiding this comment.
Could this file be renamed to impurity_radiation_variables please?
| 128: IterationVariable( | ||
| "f_nd_impurity_electrons(06)", | ||
| data_structure.impurity_radiation_module, | ||
| "f_nd_impurity_electrons(05)", |
Collaborator
There was a problem hiding this comment.
Why have some of the numbers here changed (and in lines below)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.