Skip to content

Convert neoclassics vars to dataclass#4263

Merged
timothy-nunn merged 3 commits into
mainfrom
Neoclassics-dataclass
May 20, 2026
Merged

Convert neoclassics vars to dataclass#4263
timothy-nunn merged 3 commits into
mainfrom
Neoclassics-dataclass

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented May 19, 2026

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould mentioned this pull request May 19, 2026
68 tasks
@clmould clmould marked this pull request as ready for review May 19, 2026 16:27
@clmould clmould requested a review from a team as a code owner May 19, 2026 16:27
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2026

Codecov Report

❌ Patch coverage is 84.52381% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.13%. Comparing base (adf43c5) to head (cc93f87).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/models/stellarator/neoclassics.py 60.60% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4263      +/-   ##
==========================================
- Coverage   50.16%   50.13%   -0.04%     
==========================================
  Files         151      151              
  Lines       29363    29343      -20     
==========================================
- Hits        14730    14710      -20     
  Misses      14633    14633              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould force-pushed the Neoclassics-dataclass branch from a0f6c96 to cec5e6b Compare May 20, 2026 09:23
Comment thread process/data_structure/neoclassics_variables.py Outdated
@timothy-nunn timothy-nunn enabled auto-merge (squash) May 20, 2026 09:33
@timothy-nunn timothy-nunn merged commit 11881e8 into main May 20, 2026
10 of 11 checks passed
@timothy-nunn timothy-nunn deleted the Neoclassics-dataclass branch May 20, 2026 09:39
@timothy-nunn timothy-nunn added the Data structure Issues related to the data structure label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Data structure Issues related to the data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants