Skip to content

Convert stellarator vars to dataclass#4259

Open
clmould wants to merge 2 commits into
mainfrom
Stellarator-dataclass
Open

Convert stellarator vars to dataclass#4259
clmould wants to merge 2 commits into
mainfrom
Stellarator-dataclass

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented May 15, 2026

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould force-pushed the Stellarator-dataclass branch from 53c0442 to dc13b81 Compare May 18, 2026 11:00
@clmould clmould mentioned this pull request May 18, 2026
66 tasks
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 18, 2026

Codecov Report

❌ Patch coverage is 73.01587% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.20%. Comparing base (226576d) to head (ce18343).

Files with missing lines Patch % Lines
process/models/stellarator/coils/calculate.py 23.07% 20 Missing ⚠️
process/models/stellarator/stellarator.py 0.00% 14 Missing ⚠️
process/models/physics/physics.py 0.00% 9 Missing ⚠️
process/models/stellarator/heating.py 11.11% 8 Missing ⚠️
process/models/stellarator/divertor.py 0.00% 6 Missing ⚠️
process/models/physics/plasma_geometry.py 0.00% 3 Missing ⚠️
process/models/physics/plasma_current.py 60.00% 2 Missing ⚠️
process/core/caller.py 0.00% 1 Missing ⚠️
process/core/output.py 0.00% 1 Missing ⚠️
process/core/solver/constraints.py 50.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4259      +/-   ##
==========================================
- Coverage   50.23%   50.20%   -0.04%     
==========================================
  Files         151      151              
  Lines       29365    29345      -20     
==========================================
- Hits        14752    14732      -20     
  Misses      14613    14613              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould force-pushed the Stellarator-dataclass branch from dc13b81 to ce18343 Compare May 19, 2026 09:03
@clmould clmould marked this pull request as ready for review May 19, 2026 09:18
@clmould clmould requested a review from a team as a code owner May 19, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants