Skip to content

Conversation

@harisood
Copy link
Member

This is a restructure that will allow us to action #20

Co-authored-by: Davsarper <118986872+Davsarper@users.noreply.github.com>
@harisood harisood requested a review from manics November 23, 2023 16:31
@harisood harisood mentioned this pull request Nov 23, 2023
2 tasks
@manics
Copy link
Member

manics commented Nov 28, 2023

I haven't reviewed this yet, but if we're moving pages we should add in some redirects to avoid breaking incoming links.

@harisood
Copy link
Member Author

How important tis that/easy to fix? I don't think there are many external places we have links stored to atm, so not too fussed by it.

Alternatiely a 404 catch all that redirects to the home page would probs be fine

@manics
Copy link
Member

manics commented Nov 28, 2023

We don't know which third parties are publically or privately linking to us, and I think it's good practice to avoid breaking links without good reason. There are extensions to help with redirects, e.g.
https://github.com/wpilibsuite/sphinxext-rediraffe

Copy link
Member

@Davsarper Davsarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change being the slack I am ready to approve, yet I think we should resolve the links redirect conversation.

@@ -0,0 +1,3 @@
# Our contact information

To be added
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be a different set of contact details from the Slack and mailing lists?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also including the uktrecommunity email


## [](contact.md)

The different ways you can get involved with the community!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this description right? "contact.md" just implies getting in touch, whereas it sounds like this is more about getting involved? So maybe "join-us.md"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! We are suggesting having a more in depth get involved elsewhere - so maybe a wording change above?

harisood and others added 2 commits November 28, 2023 16:27
Co-authored-by: Simon Li <spli@dundee.ac.uk>
Co-authored-by: Simon Li <spli@dundee.ac.uk>
harisood and others added 2 commits November 28, 2023 16:30
Co-authored-by: Simon Li <spli@dundee.ac.uk>
manics and others added 3 commits November 30, 2023 10:25
Co-authored-by: harisood <67151373+harisood@users.noreply.github.com>
@harisood harisood requested a review from manics November 30, 2023 12:46
Davsarper
Davsarper previously approved these changes Nov 30, 2023
@harisood
Copy link
Member Author

@manics are you happy to merge this and add redirects as a separate issue to be addressed, or should we include it within this PR?

(I think I know what the right answer is but I'm asking anyway...)

@manics
Copy link
Member

manics commented Nov 30, 2023

Can we do it in this PR since it affects the live site? If you don't want to use one of the plugins that creates automatic redirects you could recreate the old pages and include a link to the new pages instead, or if there's no replacement link to the github file pinned by commit.

Davsarper added a commit that referenced this pull request Jan 30, 2024
Uploading file for community proposal as an independent PR separate from #21
@Davsarper Davsarper marked this pull request as draft January 31, 2024 09:44
@Davsarper
Copy link
Member

I have converted to draft, most content will be copied over to the final website structure and this specific PR probably closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants