Add SimpleAdapter Annotation by RobertKeazor · Pull Request #8 · ujavid/Kombind

RobertKeazor · 2019-04-14T16:17:37Z

@gregriggins36 @ujavid, Im adding a code gen for generating a simple Kombind adapter. So @SimpleKombindAdapter(..layResId..) items: MutableLiveArrayList<*> Will generate a KombindAdapter class. The adapter class will be generated with the following signature

Kombind_[propertyName]_Adapter(items: MutableLiveArrayList, handler: Any) { ...} . For right now it can't support Multiple types. Will be cleaning up the code, and updating the sample project

Created a annotation for use when a simple RecyclerViewAdapter, through Kombind. This will eliminate the need of creating the adapter boilerplate yourself. The annotation should be attached to a ObservableList<T> field

…thods

gregriggins36

Pretty slick, I never used javapoet or kotlinpoet.
Are you trying to just avoid creating the adapter class for a simple list of items? How do you specify methods in the handler?

anontation/build.gradle

app/src/main/java/com/umairjavid/kombindsample/ui/main/MainViewModel.kt

gregriggins36 · 2019-04-14T19:56:15Z

processor/src/main/java/com/umairjavid/kombind/processor/AdapterProcessor.kt

+            if (it is VariableElement)
+                generateAdapterClass(it, layoutRes)
+        }
+        return false


We always return false?

From my understanding , this method must always return false, if not other annotations/rounds will not be processed.

RobertKeazor · 2019-04-14T20:41:47Z

@gregriggins36 Yep! So in essence, in your viewmodel you can do @SimpleKombindAdapter(layoutRES) val items: MutableLiveArrayList() and the RecyclerViewAdapter will be autogenerated for you. Yea my first time using it as well lol :'D. Took abit of getting used to to say the least. You sort have to think of things differently because annotation processing happens before compilation. So you have no access to Objects instance, but instead Elements that make up the class itself. KotlinPoet simplifies a-lot of things, which would have been extremely tedious to do without. As for Handler, it is a constructor parameter of type any, so the user will need to pass in there own handler

anontation/.gitignore

ujavid · 2019-04-14T22:06:43Z

You're timing couldn't have been better, I was thinking of solving a problem at work by generating a class based off of an interface/base class. This looks pretty cool!

…is to allow the user to specify a multi layout Recyclerview adapter

RobertKeazor · 2019-04-15T01:10:56Z

@ujavid Only thing is KotlinPoet, is a 3rd party api.But on the other hand the actually processor isn't shipped with the APK. Only the classes it generates :-D, so Cap1 should be good with it. The beauty of Kapt. Yea dude its pretty cool, once you past the complexity lol. So for Adapters that supports multiple types, the user just needs to do @SimpleKombindAdapter without specifying a layout res. This will generate an Abstract adapter, and the user just needs to override getLayout. Take a look at MainActivity and MainState.

…ist<*>.Update build.gradle

ujavid · 2019-04-20T05:01:45Z

app/build.gradle

 dependencies {
    implementation fileTree(include: ['*.jar'], dir: 'libs')
    implementation project(':kombind')
+    compileOnly project(':anontation')


ujavid · 2019-04-20T05:02:10Z

app/src/main/java/com/umairjavid/kombindsample/ui/main/MainActivity.kt

            layoutManager = LinearLayoutManager(this@MainActivity)
-            adapter = SimpleItemAdapter(viewModel.state.items, viewModel)
-                    .registerObserver(this@MainActivity)
+            adapter = object : Kombind_items_Adapter(viewModel.state.items, viewModel) {


how is the name Kombind_items_Adapter determined? why not make it KombindItemsAdapter?

the actual name of the class is taken from the annotated variable name.
So if you have @SimpleAdapter val someVariable: MutableLiveArrayList
The generated class will be called Kombind_someVariable_Adapter. For ref look at AdapterProcessor.kt Line 60

ujavid · 2019-04-20T05:03:01Z

processor/build.gradle

+sourceCompatibility = "7"
+targetCompatibility = "7"
+buildscript {
+    ext.kotlin_version = '1.3.21'


why not use the one defined in the project build.gradle?

ujavid · 2019-04-20T05:03:23Z

processor/build.gradle

+        mavenCentral()
+    }
+    dependencies {
+        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"


isn't this defined in the build.gradle?

ujavid · 2019-04-20T05:03:39Z

processor/build.gradle

+    implementation 'com.squareup:kotlinpoet:1.2.0'
+}
+
+sourceCompatibility = "7"


why not 8 as @gregriggins36 mentioned?

Yea I thought about it, I don't know if its useful for the sourceCompatibility to be the same as the JVM Target.. Wouldn't it be safer for it to be compatible with a lesser version?

ujavid · 2019-04-20T05:24:50Z

processor/src/main/java/com/umairjavid/kombind/processor/AdapterProcessor.kt

+        val kombindAdapterName = "KombindAdapter"
+        val viewHolder = "KombindAdapter.ViewHolder"
+        val fileName = element.simpleName
+        val className = "Kombind_${fileName}_Adapter"


in that case, can you change this? first it seems like it's not really fileName but elementName
second, could you do: "Kombind${elementName.capitalize()}Adapter"

also how does this handle duplicate classes with the same name?

Thats a good question lol. Perhaps I'll save the names in a set, and if the name has already been used I will add the enclosing class name as a namespace. Or have the user specify the name, with the annotation and error if the name has been used. What do you think?

@ujavid Ok just updated this . Now the generated class will including the enclosing class name of the property.
for instance : In MainState.k there is @SimpleKombindAdapter val items = MutableLiveArrayList
This generated a class called, KombindItemsAdapter_MainState.
It shouldn't be possible to have duplicate names with that signature structure,

ujavid · 2019-04-20T05:25:12Z

processor/src/main/java/com/umairjavid/kombind/processor/AdapterProcessor.kt

+        val appPackageName = processingEnv.elementUtils.getPackageOf(element).simpleName.toString()
+        val kombindAdapterName = "KombindAdapter"
+        val viewHolder = "KombindAdapter.ViewHolder"
+        val fileName = element.simpleName


rename to elementName

2.) Remove redundant build.gradle kotlin dependency 3.) Update generated class name

RobertKeazor · 2019-04-20T05:47:45Z

@ujavid Just made a commit fixing the naming and the spelling

processor/src/main/java/com/umairjavid/kombind/processor/AdapterProcessor.kt

…bleName]

…]_[VariableName]" This reverts commit f7f701a.

…bleName]

rkeazor added 3 commits April 9, 2019 11:44

Add SimpleKombindAnnotation

5a01245

Created a annotation for use when a simple RecyclerViewAdapter, through Kombind. This will eliminate the need of creating the adapter boilerplate yourself. The annotation should be attached to a ObservableList<T> field

Fix Generated Adapter and add constructor parameters and overriden me…

ca18557

…thods

Fix Spacing

67c1930

gregriggins36 reviewed Apr 14, 2019

View reviewed changes

Remove unused MainViewModel.data, clean up Adapter Processor

c21da9d

ujavid reviewed Apr 14, 2019

View reviewed changes

anontation/.gitignore Show resolved Hide resolved

Make Abstract when Layout Res is not specified with annotation. This …

c5df267

…is to allow the user to specify a multi layout Recyclerview adapter

Add conidition to make sure that element is of type MutableLiveArrayL…

1ceeb52

…ist<*>.Update build.gradle

ujavid reviewed Apr 20, 2019

View reviewed changes

1.) Fix module misspelling (annotation module)

7304466

2.) Remove redundant build.gradle kotlin dependency 3.) Update generated class name

Add enclosing class name as generated class signiture

78d0e08

ujavid reviewed Apr 20, 2019

View reviewed changes

processor/src/main/java/com/umairjavid/kombind/processor/AdapterProcessor.kt Outdated Show resolved Hide resolved

rkeazor added 3 commits April 21, 2019 12:19

Rename Generated class name to: KombindAdater_[EnclosingClass]_[Varia…

f7f701a

…bleName]

Revert "Rename Generated class name to: KombindAdater_[EnclosingClass…

2578622

…]_[VariableName]" This reverts commit f7f701a.

Rename Generated class name to: KombindAdater_[EnclosingClass]_[Varia…

e19de55

…bleName]

Comments

Conversation

RobertKeazor commented Apr 14, 2019

Uh oh!

gregriggins36 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RobertKeazor commented Apr 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ujavid commented Apr 14, 2019

Uh oh!

RobertKeazor commented Apr 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RobertKeazor commented Apr 20, 2019

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RobertKeazor commented Apr 14, 2019 •

edited

Loading

RobertKeazor commented Apr 15, 2019 •

edited

Loading