fix multiple submit issue. now show CircularProgressIndicator instead…#349
Open
poriya219 wants to merge 1 commit intoueman:masterfrom
Open
fix multiple submit issue. now show CircularProgressIndicator instead…#349poriya219 wants to merge 1 commit intoueman:masterfrom
poriya219 wants to merge 1 commit intoueman:masterfrom
Conversation
… of TextButton when submiting
Contributor
|
The changes are working correctly on my side. Kindly review and proceed with merging this pull request. |
roylenz
reviewed
Jul 29, 2025
roylenz
left a comment
There was a problem hiding this comment.
I also needed something similar, so I copied the string feedback widget and modified it to have the loading bool in the state.
I think this is a really good change to have but in my opinion modifying the feedbackBuilder signature is problematic as it creates a breaking change to everyone using it so far, and this change shouldn't really affect people that use the feedbackBuilder parameter as they probably have loading indicators of their own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix multiple submit issue. now show CircularProgressIndicator instead…
📜 Description
fix multiple submit issue. now show CircularProgressIndicator instead of TextButton when submitting.
💡 Motivation and Context
this changes fix this issue:
#345
💚 How did you test it?
I created a test flutter app and used this updated package in this app and everything worked. also, I ran a web server from the example app in the repository, and everything worked.
📝 Checklist
🔮 Next steps