fix: handle id mutation batches and task PR gates#272
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 804721f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2afee6437
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- cap sync primary-id mutation fanout by mutationBatchSize - keep legacy scheduled cursors on query pagination - cover async primary-id batches above mutationMaxRows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fixes the Resend scaffold
_idupdate/deleteallowFullScanfailure, primary-id mutation batching, and task PR-body contract regressions.🟢 95-100% confidence
_id IN (...)update/delete hit the full-scan guard; Codex review reproduced unbounded per-id fanout and legacy cursor resume risk; task PR-body regressions were reproduced against the accepted task body contract.mutationMaxRows; full repo check and local autoreview pass; unresolved review threads are empty.✅ Outcome
allowFullScan._id inArray(...)update/delete rejects lists abovemutationBatchSizebefore issuing point reads.mutationMaxRows.🏗️ Design
allowFullScanto generated Resend files would hide a bounded primary-id mutation behind a scan opt-in.🧪 Verified
bunx vitest run packages/kitcn/src/orm/mutation-id-fast-path.vitest.tsbunx tsc --noEmit --pretty false -p packages/kitcn/tsconfig.jsonbun lint:fixbun --cwd packages/kitcn buildbun check.agents/skills/autoreview/scripts/autoreview --mode localbash .agents/skills/resolve-pr-feedback/scripts/get-pr-comments 272(review_threads: [])