Fundamental test coverage of userdb module reusing existing structure.#370
Merged
jonasbardino merged 6 commits intonextfrom Jan 29, 2026
Merged
Fundamental test coverage of userdb module reusing existing structure.#370jonasbardino merged 6 commits intonextfrom
jonasbardino merged 6 commits intonextfrom
Conversation
jonasbardino
added this to the
Python3 support for general research data sites milestone
jonasbardino
added
the
test-only
jonasbardino
modified the milestones:
Python3 support for general research data sites,
Unit test coverage of everything
jonasbardino
added
the
follow-up pending
jonasbardino
force-pushed
the
add/mig-shared-userdb-unit-tests
branch
from
dfca598 to
a170511
Compare
jonasbardino
force-pushed
the
add/mig-shared-userdb-unit-tests
branch
2 times, most recently
from
51a7e58 to
44b7f35
Compare
albu-diku
reviewed
Jan 4, 2026
albu-diku
reviewed
Jan 4, 2026
albu-diku
reviewed
Jan 4, 2026
albu-diku
reviewed
Jan 4, 2026
albu-diku
reviewed
Jan 4, 2026
albu-diku
reviewed
Jan 4, 2026
albu-diku
requested changes
Jan 4, 2026
Contributor
albu-diku
left a comment
albu-diku
left a comment
There was a problem hiding this comment.
Found some things in a first pass that I believe need to be addressed.
jonasbardino
force-pushed
the
add/mig-shared-userdb-unit-tests
branch
2 times, most recently
from
73b90ab to
8b858c7
Compare
Contributor
Author
Thanks for reviewing. I've made another pass to address your feedback so I'll request another review. |
jonasbardino
force-pushed
the
add/mig-shared-userdb-unit-tests
branch
3 times, most recently
from
31d5f20 to
f057cf5
Compare
albu-diku
reviewed
Jan 29, 2026
albu-diku
approved these changes
Jan 29, 2026
Contributor
albu-diku
left a comment
albu-diku
left a comment
There was a problem hiding this comment.
I've left a comment about the naming of one of these tests, I tihnk it would be a small change that would benefit the reader. Bu it's not enough to block what's here, hence adding my approval.
…underlying `userdb` module and in particular the locking from `fileio`.
individual tests as suggested in PR review.
* remove excess user db load in save test * rename pickle test to explain abi check and split into load and save test * fork a `_generate_sample_db` helper from `_create_sample_db` for abi test * clarify how thread-safety test emulates concurrent multi-threaded access
… results indirectly with API calls to direct checking e.g. using pickle load and dump. Split joint testing of several load scenarios into individual tests to ease regression tracking. Add a save+load cycle integration test instead. Add save empty db test.
jonasbardino
force-pushed
the
add/mig-shared-userdb-unit-tests
branch
from
f057cf5 to
46daca1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fundamental test coverage of
userdbmodule reusing existing structure.Some tests are disabled on purpose because changes are needed in the tested module. Marked as follow-up.