Skip to content

Improve CI output #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stellaprins merged 18 commits into from
Jul 30, 2025
Merged

Improve CI output #22

stellaprins merged 18 commits into from
Jul 30, 2025

Conversation

@stellaprins
Copy link
Collaborator

@stellaprins stellaprins commented Jul 30, 2025 •
edited
Loading

What does this PR do?
runUnitTests_show_results:

  • improved order in which the test results are shown (number of passed / failed tests and list of failed tests are shown at the top)
  • colour coding for clarity (✅ / ❌)
  • adds a note at the end of the test results report on how to find more test details (e.g. by downloading the artifact)
  • non zero exit code if at the end of the report so that CI fails if there are failed tests (this will also draw immediate attention to the section in the CI report that shows the test results)

unit_tests.yml:

  • seperates create artifact and test results workflow steps for increased clarity in the report
  • reordering and renaming of some of the workflow steps for clarity

See the new CI output here (once it has finished running).

Linked issues
#9

stellaprins added 18 commits July 28, 2025 12:30
@stellaprins
change workflow settings for testing
ea8bfd7
@stellaprins
remove test info for failed tests
abbfda7
@stellaprins
run workflow on all tests
5d90eae
@stellaprins
refactor workflow: separate show test results and create artifact steps
aff0b7e
@stellaprins
enhance display of results
7d4678c
@stellaprins
Merge branch 'ucl-bug:main' into sp/improve_CI_output_2
5d6576f
@stellaprins
exit if test fails
cf0fc46
@stellaprins
Merge branch 'sp/improve_CI_output_2' of https://github.com/stellapri…
02f24e6 
…ns/k-wave into sp/improve_CI_output_2
@stellaprins
run kWaveDiffusion_compare_3D_heterog tests
9aac0c4
@stellaprins
replace exit with error for failed unit tests in CI integration
d30bac8
@stellaprins
add spacing before error message for failed unit tests in CI integration
6196596
@stellaprins
remove unnecessary display messages after saving unit test results
d46e934
@stellaprins
add failure messages and change exit to error for failed unit tests i…
094d890 
…n CI integration
@stellaprins
non zero exit status
4764e9f
@stellaprins
add message before exit to indicate CI detection of failed tests
ceed84b
@stellaprins
run on all tests
78621de
@stellaprins
adjust formatting
1e0aeef
@stellaprins
correct workflow triggers
0fb5149
@stellaprins stellaprins requested a review from bencox July 30, 2025 07:43
@stellaprins stellaprins self-assigned this Jul 30, 2025
@stellaprins stellaprins added the optimisation Optimisation of existing feature label Jul 30, 2025
bencox
bencox approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@bencox bencox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to follow - looks good.

@stellaprins stellaprins marked this pull request as ready for review July 30, 2025 12:07
@stellaprins stellaprins merged commit 23d93e5 into ucl-bug:main Jul 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bencox bencox bencox approved these changes

Assignees

@stellaprins stellaprins

Labels

optimisation Optimisation of existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stellaprins @bencox