-
Notifications
You must be signed in to change notification settings - Fork 185
New Quizzes Accommodations #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Quizzes Accommodations #699
Conversation
…s (accommodations and graphql)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #699 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 3788 3801 +13
=========================================
+ Hits 3788 3801 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dgwn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few misspellings of accommodations, notably in fixtures/new_quiz.json (set_new_quizzes_accomodations_quiz_level and ..._course_level), references to these properties in the tests, as well as one in the CHANGELOG. I think I've marked all occurrences.
Otherwise, LGTM. Both methods work as expected
dgwn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made as requested. LGTM 👍
emanuelGitCodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Running the function locally works.
- Able to access a student and update their accommodation.
- GraphQL runs
- Tested it using old queries that I had, and everything returned as expected.
dmols
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both functions work as intended and graphql calls return a dict object without any errors. Looks good!
Proposed Changes
Requesterto accept JSON data (asdict) directlyRequesterFixes #691