Skip to content

Conversation

@Thetwam
Copy link
Member

@Thetwam Thetwam commented Aug 4, 2025

Proposed Changes

  • Add coverage for New Quizzes Accommodations
  • Alter Requester to accept JSON data (as dict) directly
  • Updated GraphQL endpoint to match new Requester

Fixes #691

@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9aeb6e6) to head (daf75bc).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #699   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        75           
  Lines         3788      3801   +13     
=========================================
+ Hits          3788      3801   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Thetwam Thetwam self-assigned this Aug 4, 2025
Copy link
Member

@dgwn dgwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few misspellings of accommodations, notably in fixtures/new_quiz.json (set_new_quizzes_accomodations_quiz_level and ..._course_level), references to these properties in the tests, as well as one in the CHANGELOG. I think I've marked all occurrences.

Otherwise, LGTM. Both methods work as expected

@Thetwam Thetwam requested a review from dgwn August 8, 2025 18:41
Copy link
Member

@dgwn dgwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made as requested. LGTM 👍

Copy link

@emanuelGitCodes emanuelGitCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Running the function locally works.
    • Able to access a student and update their accommodation.
  • GraphQL runs
    • Tested it using old queries that I had, and everything returned as expected.

Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both functions work as intended and graphql calls return a dict object without any errors. Looks good!

@Thetwam Thetwam merged commit 1bb9920 into ucfopen:develop Aug 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Quizzes Accommodations

4 participants