Adds gradients and related features, also fixes contrast form parent issue #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds initial gradient support - Begins work on getting / modifying backgrounds from parent elements
ewainberg
changed the title
- Red dotted focus line will now draw around the text relevant to the issue as well as the background - Fixes outdated logic for getTextColor, now supports new framework with textColorXpath NOTE: triggerLiveUpdate() will break the dotted focus box for reasons unknown, will be fixed later somewhere else
dmols
requested changes
Nov 18, 2025
Contributor
dmols
left a comment
dmols
left a comment
There was a problem hiding this comment.
The form works great! I just have a few requests that I believe would make the form a little better:
- I would make it so that by default it only shows 3-4 colors in the instructions but allow the user to show the full list if there's more than that. This way, if the user is just trying to navigate past the issue, the 'next' button will be visible and not pushed down out of frame.
- Navigation is nearly done, I believe. However, tabbing through the colors should probably associate the 'X' or check mark to the color, when focusing on the color div, so an unsighted user can know the color isn't valid yet.
dmols
requested changes
Dec 4, 2025
Contributor
dmols
left a comment
dmols
left a comment
There was a problem hiding this comment.
I like the change to reduce the amount of colors on screen! I do think the screenreader additions are good but they're missing some changes to fully make this accessible:
- When the user lightens or darkens the color, it should probably tell the user what the ratio is afterwards, since that's something we sighted users can notice without losing focus of the light/darken buttons.
- As of now, the background color button is the only one that tells you if you've reached valid contrast. We should probably also mention that in the text color button as well.
I'm not sure of the best way to do this without it being too much noise for the user, or if these are things we'd particularly want to mention to the user in this manner. Thoughts, @mbusch3?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.