feat: add X server connection retry mechanism#429
Closed
chenjun1982 wants to merge 1 commit intoubuntu:mainfrom
Closed
feat: add X server connection retry mechanism#429chenjun1982 wants to merge 1 commit intoubuntu:mainfrom
chenjun1982 wants to merge 1 commit intoubuntu:mainfrom
Conversation
Author
|
When the Linux system restarts, LightDM starts the X service. LightDM then connects to the X service after receiving signal 10 from it. At this point, the X service may reset and resend signal 10, but LightDM does not reprocess this signal, resulting in a black screen. |
Added configurable retry mechanism for X server connection failures when receiving SIGUSR1 signal. The system now supports retrying connection attempts with configurable timeout and maximum retry count. This improves reliability when X server startup encounters temporary issues. New configuration options in lightdm.conf: - xserver-retry-on-connection-failure: Enable/disable retry mechanism - xserver-retry-timeout: Timeout in seconds for retry attempts (default:5) - xserver-retry-max-count: Maximum retry attempts (default: 3) The implementation tracks retry attempts, sets up timeout handlers, and properly cleans up resources. Connection success stops the retry mechanism immediately, while failures continue retrying until timeout or max attempts are reached. Log: Added automatic retry for X server connection failures Influence: 1. Test X server startup with normal successful connection 2. Test X server connection failure scenario with retry mechanism enabled 3. Verify retry timeout behavior with different timeout values 4. Test maximum retry count enforcement 5. Verify configuration options work correctly in lightdm.conf 6. Test retry mechanism disabled configuration 7. Verify resource cleanup after connection success/failure 8. Test additional SIGUSR1 signals after successful connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added configurable retry mechanism for X server connection failures when receiving SIGUSR1 signal. The system now supports retrying connection attempts with configurable timeout and maximum retry count. This improves reliability when X server startup encounters temporary issues.
New configuration options in lightdm.conf:
The implementation tracks retry attempts, sets up timeout handlers, and properly cleans up resources. Connection success stops the retry mechanism immediately, while failures continue retrying until timeout or max attempts are reached.
Log: Added automatic retry for X server connection failures
Influence: