Conversation
psteiger
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were resulting on startActivityForResult to invoke an Uber app for sso. This results in subpar UX and is buggy because it creates a new instance of the Uber app's activity which shows on top of the third party's app stack. So, we are changing the implementation a little big and returning the result via redirect uri that was passed using the sso_config.json configuration from the third party app.
The authCode will be passed in the fragment of the redirect uri as mentioned in this RFC
The authCode will only be returned if all other config information that was setup on the Uber developer dash for the third party app matches with the authorization request.
This does not change the integration point of the calling app but is a change inside the sdk itself.
Also, adding calling app package to the intent to have a sanity validation on the Uber app for redirect uri match